Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added support for multiple form elements on one page #83

Merged
merged 1 commit into from
Sep 27, 2023
Merged

fix: added support for multiple form elements on one page #83

merged 1 commit into from
Sep 27, 2023

Conversation

rasstislav
Copy link
Contributor

fixed #50

Copy link
Collaborator

@GuySartorelli GuySartorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was going to ask for some behat test coverage for this scenario, but I took a look and the current behat tests don't test the front-end at all so I think that would be out of scope for this PR.

I've been thinking this over, as I mentioned in my previous change request I wasn't sure if there were edge cases that this would break. I can't think of any specific scenario where that would happen - I don't think it's likely at all that someone has customisations for this elemental block, rather customisations are likely to be in the userforms itself which this change won't affect.

Thank you for submitting this. It works great.

@GuySartorelli GuySartorelli merged commit cc74ea4 into dnadesign:3.3 Sep 27, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants